Skip to content

Update DepthFirstSearchIterative.js #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shrivalidutt
Copy link

@shrivalidutt shrivalidutt commented Oct 8, 2024

Added a check at the start of DFSIterative to handle the case where the starting node doesn't exist. This prevents runtime errors and informs the user.

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Added a check at the start of DFSIterative to handle the case where the starting node doesn't exist. This prevents runtime errors and informs the user.
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (18da83a) to head (947b2b9).

Files with missing lines Patch % Lines
Graphs/DepthFirstSearchIterative.js 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.02%     
==========================================
  Files         378      378              
  Lines       19744    19748       +4     
  Branches     2951     2951              
==========================================
  Hits        16715    16715              
- Misses       3029     3033       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appgurueu
Copy link
Collaborator

See #1722. What this PR implements is also worse than throwing an error (side effect of logging), and it contains unnecessary style regressions.

@appgurueu appgurueu closed this Oct 8, 2024
@appgurueu appgurueu added the invalid Doesn't seem right label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants