fix: hadnle zeros at the endpoints in BisectionMethod
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 84.07% 84.09% +0.02%
==========================================
Files 375 375
Lines 19688 19687 -1
Branches 2913 2914 +1
==========================================
+ Hits 16552 16556 +4
+ Misses 3136 3131 -5 ☔ View full report in Codecov by Sentry. |
vil02
force-pushed
the
fix_bisection_method
branch
from
d4baaca to
ab6ffc9
Compare
vil02
force-pushed
the
fix_bisection_method
branch
from
ab6ffc9 to
f2f10bd
Compare
raklaptudirm
previously approved these changes
Mar 18, 2024
vil02
changed the title
BisectionMethod
vil02
changed the title
BisectionMethodBisectionMethod
appgurueu
previously approved these changes
Mar 26, 2024
Co-authored-by: appgurueu <[email protected]>
appgurueu
approved these changes
Mar 27, 2024
raklaptudirm
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
findRooterrors when one is trying to find a root forx^3on the interval[-1, 1]. This PR fixes that and adds a testcavecase covering:JavaScript/Maths/BisectionMethod.js
Line 29 in 4a4ed57
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.