Skip to content

fix: throw form DateToDay #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: throw form DateToDay #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Conversions/DateToDay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ const daysNameArr = [
const DateToDay = (date) => {
// firstly, check that input is a string or not.
if (typeof date !== 'string') {
return new TypeError('Argument is not a string.')
throw new TypeError('Argument is not a string.')
}
// extract the date
let [day, month, year] = date.split('/').map((x) => Number(x))
// check the data are valid or not.
if (day < 1 || day > 31 || month > 12 || month < 1) {
return new TypeError('Date is not valid.')
throw new TypeError('Date is not valid.')
}

// In case of Jan and Feb:
Expand Down
53 changes: 23 additions & 30 deletions Conversions/test/DateToDay.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,28 @@
import { DateToDay } from '../DateToDay'

test('The date 18/02/2001 is Sunday', () => {
const res = DateToDay('18/02/2001')
expect(res).toBe('Sunday')
})

test('The date 18/12/2020 is Friday', () => {
const res = DateToDay('18/12/2020')
expect(res).toBe('Friday')
})
describe('DateToDay', () => {
it.each([
['18/02/2001', 'Sunday'],
['18/12/2020', 'Friday'],
['12/12/2012', 'Wednesday'],
['01/01/2001', 'Monday'],
['1/1/2020', 'Wednesday'],
['2/3/2014', 'Sunday'],
['28/2/2017', 'Tuesday'],
['02/03/2024', 'Saturday'],
['29/02/2024', 'Thursday']
])('%s is %s', (date, day) => {
expect(DateToDay(date)).toBe(day)
})

test('The date 12/12/2012 is Wednesday', () => {
const res = DateToDay('12/12/2012')
expect(res).toBe('Wednesday')
})
test('The date 01/01/2001 is Monday', () => {
const res = DateToDay('01/01/2001')
expect(res).toBe('Monday')
})

test('The date 1/1/2020 is Wednesday', () => {
const res = DateToDay('1/1/2020')
expect(res).toBe('Wednesday')
})

test('The date 2/3/2014 is Sunday', () => {
const res = DateToDay('2/3/2014')
expect(res).toBe('Sunday')
})
it('should throw when input is not a string', () => {
expect(() => DateToDay(100)).toThrowError()
})

test('The date 28/2/2017 is Tuesday', () => {
const res = DateToDay('28/2/2017')
expect(res).toBe('Tuesday')
it.each(['32/01/2000', '00/01/2000', '15/00/2000', '15/13/2000'])(
'should throw when input is not a correct date %s',
(wrongDate) => {
expect(() => DateToDay(wrongDate)).toThrowError()
}
)
})