Skip to content

fix: throw error instead of returning it RailwayTimeConversion #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2024
Merged

fix: throw error instead of returning it RailwayTimeConversion #1625

merged 1 commit into from
Mar 2, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 29, 2024

Open in Gitpod know more

Describe your change:

Similar to ##1624.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you mark this PR as draft? Is there anything left to be done?

@vil02 vil02 marked this pull request as ready for review February 29, 2024 18:25
@vil02 vil02 requested a review from raklaptudirm as a code owner February 29, 2024 18:25
@vil02
Copy link
Member Author

vil02 commented Feb 29, 2024

Why did you mark this PR as draft? Is there anything left to be done?

No. I was just waiting for the CI to finish.

@raklaptudirm raklaptudirm merged commit 894a46c into TheAlgorithms:master Mar 2, 2024
@vil02 vil02 deleted the throw_in_RailwayTimeConversion branch March 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @appgurueu @raklaptudirm