Skip to content

Create pull_request_template.md #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2020
Merged

Create pull_request_template.md #153

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fde35b4
Create pull_request_template.md
itsvinayak May 6, 2020
bea2bbc
Update pull_request_template.md
itsvinayak May 6, 2020
a1724da
Update pull_request_template.md
itsvinayak May 6, 2020
2db8e85
Update pull_request_template.md
itsvinayak May 6, 2020
9ae4b13
Update pull_request_template.md
itsvinayak May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
* [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md).
* [ ] This pull request is all my own work -- I have not plagiarized.
* [ ] I know that pull requests will not be merged if they fail the automated tests.
* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
* [ ] All new Javascript files are placed inside an existing directory.
* [ ] All filenames follow camel casing style.
* [ ] All filenames follow kebab-case style.There should be no spaces in filenames.<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ ] All filenames follow kebab-case style.There should be no spaces in filenames.<br/>
* [ ] All filenames should use the UpperCamelCase style. There should be no spaces in filenames.<br/>

**Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok, @cclauss

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.theatlantic.com/science/archive/2018/05/two-spaces-after-a-period/559304/ ;-)

* [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
* [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.