-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat: add row echelon matrix algorithm #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decomposition into a set of properly named small functions makes this reasonably readable even without comments everywhere, though I suppose some comments wouldn't hurt. The doc comment needs to be moved to the proper function though, and the error case should throw
. formatResult
should be removed in favor of just using float tolerance in testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@appgurueu I have made the modifications. Have removed the formatResult and replaced it with isTolerant
. Have changed the error cases to use throw
instead of return
. Also added the necessary comments wherever required.
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.