Skip to content

Feat: TwoSum function created with test cases #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Feat: TwoSum function created with test cases #1399

merged 12 commits into from
Oct 4, 2023

Conversation

developerr-ayush
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@developerr-ayush
Copy link
Contributor Author

hey i have registered in Hacktoberfest so does this count?

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You should use a proper JSDoc comment.
  • The Map should actually be an ES6 Map (rather than a dictionary which coerces keys to strings).
  • You should use Jest's each for the test cases. I'd probably divide them into two sets, one of tests without and the other of tests with a solution for the two sum problem.

@appgurueu appgurueu added the hacktoberfest Created during hacktoberfest label Oct 2, 2023
@developerr-ayush
Copy link
Contributor Author

i have made the following changes if I am wring at some please them can you let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Created during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants