-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat: Ciphers/MorseCode Algorithm #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this |
It's telling you that there is no need to quote these properties. You should be able to safely remove the quotes. In the case of the digits this might indeed seem dubious, but I think it plays out fine because of JS's string coercion. |
Yep! Tested the new code and it worked all the same. |
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.