Skip to content

fix: refactor PrimMST and fix bug in PriorityQueue #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 23, 2023

Conversation

paulinegarelli
Copy link
Contributor

Fixes: #1298

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Refactored PrimMST by moving PriorityQueue into its own algorithm file in Data-Structures\Heap\KeyPriorityQueue.js
Added tests for PrimMST and KeyPriorityQueue
Fixed bug in PriorityQueue (method _shiftDown)

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@appgurueu appgurueu added the fix Fixes a bug label Feb 23, 2023
@raklaptudirm raklaptudirm merged commit 566d910 into TheAlgorithms:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: method pop in PrimMST.js not working properly
3 participants