Skip to content

algorithm: letter combinations #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

hiitesh1127
Copy link
Contributor

@hiitesh1127 hiitesh1127 commented Oct 18, 2022

Open in Gitpod know more

It is one of the most common Backtracking Problems asked during interviews

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@hiitesh1127 hiitesh1127 mentioned this pull request Oct 18, 2022
11 tasks
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this a backtracking problem? At first glance this appears to be a simple combinatorial problem: Finding the cross product of the sets of possible letters for all numbers.

@hiitesh1127
Copy link
Contributor Author

hiitesh1127 commented Oct 19, 2022

@appgurueu Sir you are correct when there are just two digits in the provided string, but if we analyze the scenario of three digits, we notice that we need to backtrack for the second digit string.

@hiitesh1127 hiitesh1127 requested a review from appgurueu October 19, 2022 08:10
@appgurueu
Copy link
Collaborator

appgurueu commented Oct 19, 2022

@appgurueu Sir you are correct when there are just two digits in the provided string, but if we analyze the scenario of three digits, we notice that we need to backtrack for the second digit string.

I wrote the following solution which got accepted in Go:

func letterCombinations(digits string) []string {
    if digits == "" {
        return []string{}
    }
    letters := [8]string{"abc", "def", "ghi", "jkl", "mno", "pqrs", "tuv", "wxyz"}
    res := []string{""}
    for _, digit := range digits {
        nextRes := []string{}
        for _, letter := range letters[digit - '2'] {
            for _, str := range res {
                nextRes = append(nextRes, str + string(letter))
            }
        }
        res = nextRes
    }
    return res
}

this problem does not inherently require recursion or backtracking? As said, it's just the cartesian product $\{a, b, c\} \times \{d, e, f\} \times \{g, h, i\}$ f.E. for $123$.

@hiitesh1127
Copy link
Contributor Author

hiitesh1127 commented Oct 19, 2022

Okay Sir,

I guess your solution is iterative and mine is recursive
My backtracking approach for this solution is
we need to backtrack for node no 3's

lettercombination

https://www.interviewbit.com/blog/letter-combinations-of-a-phone-number/

@appgurueu
Copy link
Collaborator

appgurueu commented Oct 19, 2022

Backtracking is a class of algorithm for finding solutions to some computational problems, notably constraint satisfaction problems, that incrementally builds candidates to the solutions, and abandons a candidate as soon as it determines that the candidate cannot possibly be completed to a valid solution.

- from https://en.wikipedia.org/wiki/Backtracking

I don't see how this definition is met - no "candidates" are "abandoned" (if I'm missing something, please explain). All I see is a simple combinatorial algorithm. LeetCode and InterviewBit are probably getting their terminology wrong. @raklaptudirm your opinion? Should this go under "Backtracking" or just "Recursion"?

In the Lua repo I prefer to categorize algorithms not by the applied "strategy", but rather strictly by the problem they solve.

@hiitesh1127
Copy link
Contributor Author

Please review @raklaptudirm

@raklaptudirm
Copy link
Member

I guess recursive would be best.

@hiitesh1127
Copy link
Contributor Author

I guess recursive would be best.

Okay I will update

@hiitesh1127
Copy link
Contributor Author

Done @appgurueu @raklaptudirm

@raklaptudirm raklaptudirm changed the title Added Backtracking Program algorithm: letter combinations Oct 21, 2022
@raklaptudirm raklaptudirm merged commit 63a3394 into TheAlgorithms:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants