-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add comments to all algorithms #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this largely duplication of https://github.com/TheAlgorithms/Algorithms-Explanation ? |
@cclauss That is still not an excuse to have uncommented code in my opinion. But I am open to suggestions. A discussion would be welcome. |
True |
/*
|
In my opinion we are much better served with self-documenting function and variable names so that the entities and intents of each algorithm are as clear as possible without comments. This means that comments should be reserved for areas where clear code is impossible. Vertical lines and manual spacing seems like a waste of valuable developer time and focus. |
True, add comments where clear code is impossible. And for writing the algorithm use respective variables, array, data structure names, so it will be easy to understand and no need to write comments at every algorithm. |
Well put. A full plain-english explanation is better left to the algorithms-explanation repo. |
Uh oh!
There was an error while loading. Please reload this page.
One of the main purposes of this repository is education. But for that, a comprehensive explanation of the various algorithms along with the mentioned references is required. This is achieved through well-commented code, but that is missing from many algorithms. This issue tries to start work on commenting on all the algorithms and establishing a good format for commenting. We also should check all new Pull Requests for code quality and comments.
A format suggestion for commenting:
The text was updated successfully, but these errors were encountered: