Skip to content

Fix the 3 existing PRs #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raklaptudirm opened this issue May 30, 2021 · 0 comments
Closed

Fix the 3 existing PRs #617

raklaptudirm opened this issue May 30, 2021 · 0 comments

Comments

@raklaptudirm
Copy link
Member

raklaptudirm commented May 30, 2021 •
edited
Loading

We currently have 3 existing PRs for the Javascript repository:

  1. PR #574 Update NQueen.js
  2. PR #504 Add Binary Search Tree
  3. PR #459 add De-facto unbiased shuffle Algorithm

All of them are good additions to the codebase but cannot be merged due to standardjs style problems. On the other hand, they could be merged and and standard --fix run on them on a later commit. People who want to ping the creators and make them make the change, the PRs seem to be abandoned and the users are not answering to @Pings. I need some advice regarding what to do with them.
raklaptudirm added a commit that referenced this issue Jun 7, 2021
@raklaptudirm
Merge pull request #619 from mhihasan/update_nqeen_algo [#617]
c423e6e 
Find all the solutions of NQueen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raklaptudirm