Skip to content

Files that are not compliant with standardjs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
26 of 27 tasks
cclauss opened this issue May 3, 2020 · 12 comments · Fixed by #152
Closed
26 of 27 tasks

Files that are not compliant with standardjs #139

cclauss opened this issue May 3, 2020 · 12 comments · Fixed by #152
Assignees
@juliano-nunes @christianbender @itsvinayak

Comments

@cclauss
Copy link
Member

cclauss commented May 3, 2020 •
edited
Loading

The following FilePaths fail npx standard FilePath and can not be fixed using the --fix option.
@cclauss cclauss added the help wanted Needs to be worked on label May 3, 2020
@juliano-nunes
Copy link
Contributor

Hey @itsvinayak, let me know if you need help :)

@cclauss
Copy link
Member Author

cclauss commented May 3, 2020

This work should not all be done in one pull request (to have mercy on project maintainers) and should not all be done by one developer. So if you wish to help, just fix a few files and submit a PR. You do not need to wait for permission, just dig in. ;-)

@juliano-nunes juliano-nunes mentioned this issue May 4, 2020
Merged
@juliano-nunes
Copy link
Contributor

Ok @cclauss, thank you. I have opened a PR to fix the first ones (Ciphers, Conversions and Data Structures).

@cclauss
Copy link
Member Author

cclauss commented May 4, 2020 •
edited
Loading

Nice. I look forward to seeing #140 reviewed and landed. For future pull requests, to make this process easier for the reviewers, please try to do those files where standard has just one or two objections first. This will build momentum and should quickly get the long list down to a reasonable size. For the files that require complex changes, please try to do one file per pull request.

Also, please look at https://github.com/TheAlgorithms/Javascript/actions to follow the standard testing progress. Once all files are compliant, we should remove the || true from our GitHub Action to mandate compliance on future PRs. I added this at the end of our task list above. Thanks!

@itsvinayak
Copy link
Member

itsvinayak commented May 4, 2020 •
edited by cclauss
Loading

#140 has been merged and PR #141 has been created merged.

@cclauss cclauss mentioned this issue May 4, 2020
Merged
cclauss added a commit that referenced this issue May 4, 2020
@cclauss
factorial.js: Standardjs fixes
84b06e7 
Related to #139
This was referenced May 4, 2020
Merged
Merged
@itsvinayak
Copy link
Member

#147 is merged

@cclauss
Copy link
Member Author

cclauss commented May 4, 2020 •
edited by itsvinayak
Loading

6 files left... Do you know how to solve the problem with the sorts?

@cclauss
Copy link
Member Author

cclauss commented May 5, 2020

@Nur69 Would you be willing to see if you can get Javascript/maths/graph.js to pass https://standardjs.com ? I tried but was unable to get it to pass.

@itsvinayak
Copy link
Member

6 files left... Do you know how to solve the problem with the sorts?

no, there is a problem with /linear-algebra-javascript/ and /sorts/ Algorithms

@cclauss
Copy link
Member Author

cclauss commented May 5, 2020 •
edited
Loading

Sort issue is
https://www.google.com/search?q=Array+prototype+is+read+only%2C+properties+should+not+be+added.

Maybe http://linterrors.com/js/extending-prototype-of-native-object

@itsvinayak
Copy link
Member

Javascript/maths/graph.js has been fixed in this commit

@itsvinayak
Copy link
Member

#152

 Javascript/linear-algebra-javascript/test/test.js
 Javascript/linear-algebra-javascript/src/la_lib.js

@cclauss cclauss removed the help wanted Needs to be worked on label May 5, 2020
@itsvinayak itsvinayak mentioned this issue May 5, 2020
Merged
BurhanH added a commit to BurhanH/Javascript that referenced this issue May 18, 2020
@BurhanH @AlexDvorak
@winsonrich @ms10398 @AkarshSatija @ntedgi @AnupKumarPanwar @raviolliii @Mavroian @yanglbme @PatOnTheBack @lakshyabatman @cclauss @NourBennour @StepfenShawn @hmizz @itsvinayak @juliano-nunes @awaistkd @NourBc @novojitsaha @samjain2907 @Satzyakiz @sahilbansal17 @abhi0977 @poyea
Fetching last changes (#1)
ccd8e8b 
* added DecimalToHex

* added luhn's checksum algorithm

* deleted checksums

* Update keyFinder.js

modified used the suitable identifier for the variables

* Update keyFinder.js

1. modified the identifiers and used the suitable identifiers for the variables
2. leave the loop when a key is match and found to increase the speed of searching in this stage of development
3. return the key number if founded, return 0 if found nothing

* Update keyFinder.js

a sub-function is used to assist the keyfinder to find the key

* Update keyFinder.js

Finally, there are several changes in the function keyFinder(str) that make it works well

* Update keyFinder.js

Add some key words to the wordbank to increase the chance of the matching.

* fixed and added test cases

* fixed alert

* Add wiggle sort

* adding Graph data structure

* Added SHA-1 and SHA-256 hashing algorithms (TheAlgorithms#83)

* Added SHA-1 and SHA-256 hashing algorithms

* Fixed typos in comments

* Removed redundant unsigned integer casting

* Added Jump Search to readme.md

* Added JumpSearch algorithm

* Update jumpSearch.js

* Added Semicolon to Avoid Auto Semicolon Insertion

This fixes a [recommendation on lgtm](https://lgtm.com/projects/g/TheAlgorithms/Javascript/snapshot/9fe2ca0492e0813c5e5486498c6b53a00c4a61e3/files/Sorts/bucketSort.js?sort=name&dir=ASC&mode=heatmap)

* Fixed Whitespace, Operators, and Quotes to Comply with JSLint

I modified the whitespace in the files and changed single quotes to double quotes.

I also changed some `==` and `!=` operators to `===` and `!==` to comply with JSLint.

* Create find_lcm.js

- Created find_lcm.js
- Created maths folder

* Create average_mean.js

* Create factorial.js

This program calculates and displays the factorial for a user-input number.

* Create abs.js

This script calculates absolute value.

* Made "use strict" Global

* Made "use strict" Global & Made JSLint Happy

* Kadane Algo is added

* Issue fixed

* GitHub Action to test Javascript

* Update nodejs.yml

* cd linear-algebra-javascript

* Create update_directory_md.yml

* updating DIRECTORY.md

* update_directory_md.yml: Remove GH Actions workaround

* Graph Theory

* Delete Graphs

* Graph

* Dijkstra Smallest Path

* DijkstraSmallestPath

after fixing some errors.

* Topological Sort 

directed graphs

* correcting name of file

* updating DIRECTORY.md

* doublylinkedlist

* add-doublylinkedlist

* add-doublylinkedlist

* change in Directory.md

* updating DIRECTORY.md

* update (#1)

* Graph Theory

* Delete Graphs

* Graph

* Dijkstra Smallest Path

* DijkstraSmallestPath

after fixing some errors.

* Topological Sort 

directed graphs

* correcting name of file

* updating DIRECTORY.md

* doublylinkedlist

* add-doublylinkedlist

* add-doublylinkedlist

* change in Directory.md

* updating DIRECTORY.md

Co-authored-by: Nur69 <[email protected]>
Co-authored-by: Stepfen Shawn <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: hmizz <[email protected]>

* Contributing guidelines

* npx standard --fix

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <[email protected]>

* Add standard to our testing

Run in allow failures mode until the non-compliant files are fixed.

* npx standard || true

* Update README.md

* Fixing non compliant files (Ciphers, Conversions and Data Structures)

* Update nodejs.yml

* Data Structures/Graph

* sorts/

* fix broken link

* search/

* search/ (TheAlgorithms#143)

* factorial.js: Standardjs fixes

Related to TheAlgorithms#139

* /* global alert, prompt */

* find_lcm.js: Standardjs fixes

* abs.js: abs_val() --> absVal() for standardjs (TheAlgorithms#144)

* find_lcm.js: Standardjs fixes (TheAlgorithms#146)

* Update factorial.js

* SHA256.js: Standardjs fixes

* factorial.js: /* global prompt */

* Update nodejs.yml

* DijkstraSmallestPath.js: Standardjs fixes (TheAlgorithms#147)

* Fixed typo in CONTRIBUTING.md file (TheAlgorithms#148)

* Fixed typo in CONTRIBUTING.md file

* Update CONTRIBUTING.md

Co-authored-by: vinayak <[email protected]>

* math/

* sort/

* Add Pascal's triangle. (TheAlgorithms#149)

* Add Pascal's triangle.

* Update pascalTriangle.js

* Update pascalTriangle.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Javascript/linear-algebra-javascript

* Update nodejs.yml

* Update nodejs.yml

* Update nodejs.yml

* Trailing space ;-)

* Update README.md

* adding an implementation of a queue using 2 stacks (TheAlgorithms#137)

* adding an implementation of a queue using 2 stacks

* Update QueueUsing2Stacks.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Create palindrome algorithm (TheAlgorithms#134)

* Create palindrome algorithm

* Update Palindrome.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Create pull_request_template.md (TheAlgorithms#153)

* Create pull_request_template.md

* Update pull_request_template.md

* Update pull_request_template.md

* Update pull_request_template.md

* Update pull_request_template.md

* Update README.md

* Update CONTRIBUTING.md

* added hcf finding algorithm (TheAlgorithms#104)

* added hcf finding algorith

* Update and rename find_hcf.js to FindHcf.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Create Fibonacci.js (TheAlgorithms#133)

* Create Fibonacci.js

* Update Fibonacci.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Javascript/Math: editing file name

* updating DIRECTORY.md

* Update nodejs.yml

* Update README.md

* editing file names

* updating DIRECTORY.md

* Quick Select Search (TheAlgorithms#131)

* HeapSort algorithm

* Create QuickSelect.js

* Algorithm to reverse a string.

* Update ReverseString.js

* Update Heapsort.js

* Update QuickSelect.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Update README.md

* Max heap implementation (TheAlgorithms#157)

* Added MaxHeap implementation

* Added MaxHeap implementation

* Added MaxHeap implementation

* Added MaxHeap implementation

* Delete package-lock.json

* Delete .gitignore

* updating DIRECTORY.md

* Renaming files according to naming convention (TheAlgorithms#158)

* updating DIRECTORY.md

* Fibonacci without recursion added (TheAlgorithms#159)

* changes made

* Update Fibonacci.js

* fib

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* format files

* updating DIRECTORY.md

* Add good_filepaths function in workflow script

* updating DIRECTORY.md

* Add md_prefix and print_path functions

* Add reverse words (TheAlgorithms#162)

* add reverse words

* Update ReverseWords.js

* Update ReverseWords.js

Co-authored-by: vinayak <[email protected]>

* updating DIRECTORY.md

* Add build_directory_md

* GitHub Action nodejs.yml upgrade to Node.js 14 (TheAlgorithms#165)

* JavaScript, not Javascript (TheAlgorithms#166)

* Rename script.js to UpdateDirectory.js

* updating DIRECTORY.md

* run: node UpdateDirectory.js

* run: node .github/workflows/UpdateDirectory.js

* updating DIRECTORY.md

* BogoSort.js: Simplify Array.isSorted() and add doctests

As discussed at TheAlgorithms#164 (comment)

Also related to add doctests as discussed in TheAlgorithms#142

* node -e "doctest('Sorts/BogoSort.js', {})"

* doctest --module Sorts Sorts/BogoSort.js

* Update nodejs.yml

* Update nodejs.yml

* npx doctest Sorts/BogoSort.js || true

* node_modules/doctest Sorts/BogoSort.js || true

* npx doctest Sorts/BogoSort.js

* updating DIRECTORY.md

* Ensure that build fail on bad test

* updating DIRECTORY.md

* Ready for review

* Add doctest to BucketSort.js

* updating DIRECTORY.md

* Update nodejs.yml

* updating DIRECTORY.md

* npx doctest Sorts/BogoSort.js Sorts/BucketSort.js

* updating DIRECTORY.md

* updating DIRECTORY.md

* Add Graph BFS algorithm (TheAlgorithms#169)

* Add Graph BFS algorithm

* updating DIRECTORY.md

* Fix failing tests

* updating DIRECTORY.md

* Fix further failing tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

* updating DIRECTORY.md

* Re-orgainze files and folders in the repository (TheAlgorithms#172)

* Re-orgainze files and folders in the repository

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Co-authored-by: Alex Brown <[email protected]>
Co-authored-by: Wan Cheuk Lun <[email protected]>
Co-authored-by: Mohit Sharma <[email protected]>
Co-authored-by: Akarsh <[email protected]>
Co-authored-by: naor <[email protected]>
Co-authored-by: Anup Kumar Panwar <[email protected]>
Co-authored-by: Ravi Patel <[email protected]>
Co-authored-by: mavroian <[email protected]>
Co-authored-by: Libin Yang <[email protected]>
Co-authored-by: PatOnTheBack <[email protected]>
Co-authored-by: lakshyabatman <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Nur69 <[email protected]>
Co-authored-by: Stepfen Shawn <[email protected]>
Co-authored-by: hmizz <[email protected]>
Co-authored-by: vinayak <[email protected]>
Co-authored-by: Juliano Nunes <[email protected]>
Co-authored-by: Muhammad Awais <[email protected]>
Co-authored-by: Nour B <[email protected]>
Co-authored-by: hmizz <[email protected]>
Co-authored-by: Novojit Saha <[email protected]>
Co-authored-by: Samarth Jain <[email protected]>
Co-authored-by: Satzyakiz <[email protected]>
Co-authored-by: Sahil Bansal <[email protected]>
Co-authored-by: Abhi Ramani <[email protected]>
Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliano-nunes juliano-nunes

@christianbender christianbender

@itsvinayak itsvinayak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Javascript/linear-algebra-javascript
4 participants
@cclauss @juliano-nunes @christianbender @itsvinayak