Skip to content

refactor: introduce SinglyLinkedListNode #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 2, 2025

This is a step towards not suppressing auxiliaryclass:

Java/pom.xml

Line 78 in 22098c7

<arg>-Xlint:-auxiliaryclass</arg>

This PR moves the Node class outside SinglyLinkedList.java.
The name SinglyLinkedListNode has the advantage that it is unique. I am open for suggestions here.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

This is a step towards not suppressing `auxiliaryclass`
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.77%. Comparing base (22098c7) to head (4e38765).

Files with missing lines Patch % Lines
...orithms/datastructures/lists/SinglyLinkedList.java 83.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6210      +/-   ##
============================================
- Coverage     73.78%   73.77%   -0.01%     
- Complexity     5296     5299       +3     
============================================
  Files           670      671       +1     
  Lines         18343    18344       +1     
  Branches       3546     3546              
============================================
  Hits          13534    13534              
- Misses         4262     4263       +1     
  Partials        547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review April 2, 2025 15:36
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 251e9e1 into TheAlgorithms:master Apr 2, 2025
6 checks passed
@vil02 vil02 deleted the introduce_SinglyLinkedListNode branch April 2, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants