Refactor existing LWWElementSet implementation #6164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s comparison - Replaced int timestamps with Instant for improved precision - Refactored class to be generic, allowing support for different types of elements - Removed bias-based comparison to align with LWW-Element-Set - Reference: https://inria.hal.science/inria-00555588v1/document
- Updated existing test cases to align with changes in LWWElementSet implementation - Improved test readability and coverage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6164 +/- ##
============================================
+ Coverage 73.94% 73.98% +0.03%
+ Complexity 5161 5159 -2
============================================
Files 662 662
Lines 17695 17681 -14
Branches 3412 3407 -5
============================================
- Hits 13085 13081 -4
+ Misses 4102 4097 -5
+ Partials 508 503 -5 ☔ View full report in Codecov by Sentry. |
itakurah
requested review from
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the existing LWWElementSet Implementation:
Added generic support to allow the set to store any type of element.
Updated Javadoc to reflect changes and improve clarity.
Refactored timestamp comparison to remove bias, following the recommendations outlined in A comprehensive study of Convergent and Commutative Replicated Data Types.
Removed the unused
comparemethod, which is no longer needed due to updated timestamp comparison logic.Updated existing test cases to align with changes in LWWElementSet implementation
Improved test readability and coverage
I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new code is formatted with
clang-format -i --style=file path/to/your/file.java