Skip to content

Update Armstrong.java #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

Patient-Pace-Coder
Copy link
Contributor

@Patient-Pace-Coder Patient-Pace-Coder commented Jan 13, 2025

Optimized Armstrong number check by removing string conversion

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Optimized Armstrong number check by removing string conversion
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (bd785de) to head (2b9869b).

Files with missing lines Patch % Lines
...c/main/java/com/thealgorithms/maths/Armstrong.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6131      +/-   ##
============================================
- Coverage     73.77%   73.75%   -0.02%     
- Complexity     5120     5121       +1     
============================================
  Files           658      658              
  Lines         17619    17620       +1     
  Branches       3391     3391              
============================================
- Hits          12998    12996       -2     
- Misses         4117     4119       +2     
- Partials        504      505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 779381f into TheAlgorithms:master Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants