Skip to content

improve zig-zag-pattern #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

r4lly99
Copy link
Contributor

@r4lly99 r4lly99 commented Jan 12, 2025

  • Simplified the logic by using row-by-row traversal with direct index calculations for efficiency
  • Added Javadoc documentation for clarity.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.76%. Comparing base (1e6ed97) to head (b648bf7).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6128      +/-   ##
============================================
- Coverage     73.78%   73.76%   -0.03%     
  Complexity     5119     5119              
============================================
  Files           658      658              
  Lines         17632    17616      -16     
  Branches       3391     3390       -1     
============================================
- Hits          13010    12994      -16     
+ Misses         4118     4117       -1     
- Partials        504      505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4lly99 r4lly99 marked this pull request as ready for review January 12, 2025 03:56
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 08c0f4a into TheAlgorithms:master Jan 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants