Skip to content

Added Goldbach's Conjecture algorithm. #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

BILLSARAN
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (39122a9) to head (ab5eb79).

Files with missing lines Patch % Lines
...va/com/thealgorithms/maths/GoldbachConjecture.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6127      +/-   ##
============================================
- Coverage     73.76%   73.75%   -0.02%     
- Complexity     5122     5126       +4     
============================================
  Files           658      659       +1     
  Lines         17621    17628       +7     
  Branches       3390     3392       +2     
============================================
+ Hits          12999    13001       +2     
- Misses         4118     4120       +2     
- Partials        504      507       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BILLSARAN BILLSARAN closed this Jan 11, 2025
@BILLSARAN BILLSARAN reopened this Jan 11, 2025
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please reuse existing algorithms for primeness check and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@BILLSARAN BILLSARAN requested a review from siriak January 13, 2025 00:02
@BILLSARAN
Copy link
Contributor Author

The code looks good, could you please reuse existing algorithms for primeness check and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

I think I did it, please let me know if anything else needs to be fixed

@BILLSARAN BILLSARAN requested a review from siriak January 13, 2025 19:15
@siriak siriak enabled auto-merge (squash) January 13, 2025 21:37
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 754bf6c into TheAlgorithms:master Jan 13, 2025
6 checks passed
@BILLSARAN BILLSARAN deleted the GoldbachBranch1 branch January 13, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants