-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Added Goldbach's Conjecture algorithm. #6127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6127 +/- ##
============================================
- Coverage 73.76% 73.75% -0.02%
- Complexity 5122 5126 +4
============================================
Files 658 659 +1
Lines 17621 17628 +7
Branches 3390 3392 +2
============================================
+ Hits 12999 13001 +2
- Misses 4118 4120 +2
- Partials 504 507 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, could you please reuse existing algorithms for primeness check and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
…h Conjecture algorithm
I think I did it, please let me know if anything else needs to be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
clang-format -i --style=file path/to/your/file.java