-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Added surface area calculation for pyramid #6062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -192,4 +192,17 @@ public static double surfaceAreaCone(final double radius, final double height) { | |||
} | |||
return Math.PI * radius * (radius + Math.pow(height * height + radius * radius, 0.5)); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as part of the lab
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6062 +/- ##
============================================
- Coverage 73.42% 73.39% -0.03%
Complexity 5078 5078
============================================
Files 656 656
Lines 17617 17624 +7
Branches 3394 3395 +1
============================================
Hits 12936 12936
- Misses 4180 4187 +7
Partials 501 501 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add JUnit tests and fix PR checks
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
clang-format -i --style=file path/to/your/file.java