-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Added surface area calculation for pyramid #5884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5884 +/- ##
============================================
- Coverage 66.81% 66.77% -0.04%
Complexity 4501 4501
============================================
Files 611 611
Lines 16958 16965 +7
Branches 3275 3276 +1
============================================
- Hits 11330 11328 -2
- Misses 5181 5189 +8
- Partials 447 448 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self Reviewed!
@@ -192,4 +192,23 @@ public static double surfaceAreaCone(final double radius, final double height) { | |||
} | |||
return Math.PI * radius * (radius + Math.pow(height * height + radius * radius, 0.5)); | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is is. Comment testing complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix linter PR check and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
clang-format -i --style=file path/to/your/file.java