Optimize BreadthFirstSearch implementation with bug fixes and improvements #5882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments - Fix potential infinite loop by adding cycle detection using HashSet - Add null value and null node handling for better robustness - Optimize visited node lookups from O(n) to O(1) using HashSet - Clear previous search results for multiple search support - Add defensive copying in getVisited() to prevent external state modification - Improve code organization and documentation - Add consistent node visitation handling - Fix root node visitation order inconsistency - Prevent redundant node processing
manishraj27
requested review from
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5882 +/- ##
============================================
- Coverage 66.98% 66.96% -0.02%
Complexity 4522 4522
============================================
Files 613 613
Lines 16985 16990 +5
Branches 3281 3282 +1
============================================
Hits 11378 11378
- Misses 5159 5161 +2
- Partials 448 451 +3 ☔ View full report in Codecov by Sentry. |
|
Hi Please review the pr and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java