Skip to content

refactor: removed main function, improved docstring, written JUnit tests for KrishnamurthyNumber. #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Tanmay-Singh3004
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.97%. Comparing base (efb16c1) to head (65faa27).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5881      +/-   ##
============================================
+ Coverage     66.86%   66.97%   +0.10%     
- Complexity     4516     4521       +5     
============================================
  Files           613      613              
  Lines         16996    16989       -7     
  Branches       3282     3281       -1     
============================================
+ Hits          11364    11378      +14     
+ Misses         5183     5163      -20     
+ Partials        449      448       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tanmay-Singh3004 Tanmay-Singh3004 marked this pull request as ready for review October 16, 2024 18:02
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 22, 2024 17:49
@siriak siriak merged commit ef72b1e into TheAlgorithms:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants