Skip to content

Update MaximumSumOfNonAdjacentElements.java #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MahaleHarsh
Copy link

@MahaleHarsh MahaleHarsh commented Oct 16, 2024

Added handling for single-element arrays.
Made the take calculation more concise.
Kept the variable update logic the same but provided better explanations. Improved comment clarity and consistency.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Added handling for single-element arrays.
Made the take calculation more concise.
Kept the variable update logic the same but provided better explanations.
Improved comment clarity and consistency.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (169a01e) to head (55199ea).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5874      +/-   ##
============================================
- Coverage     66.74%   66.72%   -0.02%     
  Complexity     4489     4489              
============================================
  Files           610      610              
  Lines         16929    16928       -1     
  Branches       3267     3268       +1     
============================================
- Hits          11299    11296       -3     
- Misses         5182     5183       +1     
- Partials        448      449       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Oct 26, 2024

Please add corresponding JUnit tests and fix PR checks

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 29, 2024
Copy link

github-actions bot commented Dec 6, 2024

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants