-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Implemented chinese remainder theorem with test file #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5873 +/- ##
============================================
+ Coverage 68.77% 68.81% +0.04%
- Complexity 4637 4644 +7
============================================
Files 621 622 +1
Lines 17116 17146 +30
Branches 3302 3308 +6
============================================
+ Hits 11771 11799 +28
- Misses 4893 4894 +1
- Partials 452 453 +1 ☔ View full report in Codecov by Sentry. |
…nese-remainder updated
siriak
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request implements the Chinese Remainder Theorem (CRT) algorithm to solve issue #5772.
The implementation includes:
solveCRT
) that calculates the solution using the product of moduli and their modular inverses.modInverse
) that computes the modular inverse using the Extended Euclidean Algorithm.Checklist
clang-format -i --style=file path/to/your/file.java
.