Create Unrolled Linked List #5835
Conversation
A linked list variant that stores multiple elements in each node to improve cache performance.
vishantrathi
requested review from
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5835 +/- ##
============================================
+ Coverage 65.99% 66.00% +0.01%
Complexity 4395 4395
============================================
Files 603 603
Lines 16799 16799
Branches 3226 3226
============================================
+ Hits 11086 11088 +2
+ Misses 5266 5265 -1
+ Partials 447 446 -1 ☔ View full report in Codecov by Sentry. |
| private Node head; | ||
| private int nodeCapacity; // Maximum capacity of each node | ||
|
|
||
| // Constructor |
There was a problem hiding this comment.
Redundant comment. Will be better to remove it.
| @@ -0,0 +1,52 @@ | |||
| class UnrolledLinkedList { | |||
| private Node head; | |||
| private int nodeCapacity; // Maximum capacity of each node | |||
There was a problem hiding this comment.
This will be better move it to javadoc
| nodeCapacity = capacity; | ||
| } | ||
|
|
||
| // Insert an element at the end |
There was a problem hiding this comment.
This also, will be better to have like javadoc
| // Constructor | ||
| public UnrolledLinkedList(int capacity) { | ||
| head = null; | ||
| nodeCapacity = capacity; |
There was a problem hiding this comment.
Need to add checking for wrong input.
public UnrolledLinkedList(int capacity) {
if (capacity <= 0) {
throw new IllegalArgumentException("Node capacity must be positive");
}
this.head = null;
this.nodeCapacity = capacity;
}
| } | ||
|
|
||
| // Display the unrolled linked list | ||
| public void display() { |
There was a problem hiding this comment.
This is redundant method because usually standard interface for List data structure not include it. You can discover standard java List interface.
| @@ -0,0 +1,52 @@ | |||
| class UnrolledLinkedList { | |||
There was a problem hiding this comment.
It is also very useful to have multiple Junit tests.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
A linked list variant that stores multiple elements in each node to improve cache performance.
clang-format -i --style=file path/to/your/file.java