Skip to content

Added edmonds algorithm #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Added edmonds algorithm #5827

wants to merge 9 commits into from

Conversation

volimroze
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.87%. Comparing base (c301fec) to head (e35b317).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/com/thealgorithms/misc/FourSumProblem.java 0.00% 24 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5827      +/-   ##
============================================
+ Coverage     64.13%   65.87%   +1.73%     
- Complexity     4205     4386     +181     
============================================
  Files           587      602      +15     
  Lines         16388    16804     +416     
  Branches       3163     3236      +73     
============================================
+ Hits          10511    11069     +558     
+ Misses         5448     5290     -158     
- Partials        429      445      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

siriak
siriak requested changes Oct 26, 2024
View reviewed changes
src/main/java/com/thealgorithms/misc/FourSumProblem.java

public class FourSumProblem {

public static List<List<Integer>> fourSum(int[] nums, int target) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't add leetcode problems

src/main/java/com/thealgorithms/datastructures/graphs/EdmondsAlgorithm.java
return false;
}

public static void main(String[] args) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace main with JUnit tests

checkstyle.xml
@@ -175,7 +175,7 @@
<!-- See https://checkstyle.org/checks/design/index.html -->
<!-- TODO <module name="DesignForExtension"/> -->
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
<!-- module name="HideUtilityClassConstructor"/> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable those modules back

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak requested changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@volimroze @codecov-commenter @siriak