Skip to content

feat: Add SpeculativeExecutionScheduling new algorithm with tests #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 14, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@Hardvan Hardvan changed the title feat: Add SpeculativeExecutionScheduling new algorithm with Junit t… feat: Add SpeculativeExecutionScheduling new algorithm with tests Oct 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (bca8d0e) to head (9139019).

Files with missing lines Patch % Lines
...hms/scheduling/SpeculativeExecutionScheduling.java 92.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5817      +/-   ##
============================================
+ Coverage     72.40%   72.42%   +0.01%     
- Complexity     4983     4989       +6     
============================================
  Files           653      654       +1     
  Lines         17574    17601      +27     
  Branches       3386     3391       +5     
============================================
+ Hits          12724    12747      +23     
- Misses         4371     4372       +1     
- Partials        479      482       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 14, 2024 13:46
@Hardvan Hardvan requested a review from siriak October 29, 2024 05:05
Task(String name) {
this.name = name;
this.completed = false;
this.startTime = -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the time when the task arrives to the system and becomes available for execution.

* @param groupName the name of the group
* @return the name of the task that completed successfully
*/
public String executeTasks(String groupName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide reference explanation of this algorithm

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 30, 2024
Copy link

github-actions bot commented Dec 7, 2024

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants