Skip to content

Refactor AtbashCipher, add ParameterizedTest #5808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 14, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.78%. Comparing base (20239f2) to head (4be1a7e).

Files with missing lines Patch % Lines
...n/java/com/thealgorithms/ciphers/AtbashCipher.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5808      +/-   ##
============================================
- Coverage     70.79%   70.78%   -0.02%     
+ Complexity     4862     4860       -2     
============================================
  Files           650      650              
  Lines         17533    17533              
  Branches       3379     3379              
============================================
- Hits          12413    12410       -3     
- Misses         4656     4659       +3     
  Partials        464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 14, 2024 10:36
@siriak siriak enabled auto-merge (squash) October 26, 2024 06:23
@siriak siriak merged commit 08bd1ff into TheAlgorithms:master Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants