Skip to content

feat: Add PhoneticAlphabetConverter new algorithm with Junit tests #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 13, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.48%. Comparing base (5a710ea) to head (9369ff3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5752      +/-   ##
============================================
+ Coverage     64.38%   64.48%   +0.09%     
- Complexity     4244     4247       +3     
============================================
  Files           593      594       +1     
  Lines         16573    16615      +42     
  Branches       3188     3189       +1     
============================================
+ Hits          10671    10714      +43     
+ Misses         5464     5463       -1     
  Partials        438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 13, 2024 04:24
@siriak siriak merged commit e9b897b into TheAlgorithms:master Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants