Skip to content

feat: Add BCDConverter new algorithm with Junit tests #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 13, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.96%. Comparing base (4a03f42) to head (b749c38).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5747      +/-   ##
============================================
+ Coverage     63.91%   63.96%   +0.05%     
- Complexity     4167     4174       +7     
============================================
  Files           582      583       +1     
  Lines         16302    16321      +19     
  Branches       3148     3151       +3     
============================================
+ Hits          10419    10440      +21     
+ Misses         5457     5456       -1     
+ Partials        426      425       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 13, 2024 04:00
@Tanmay-Singh3004
Copy link
Contributor

If it is only for the conversion purpose, then I guess #5742 covered this .
You can check that out.

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 13, 2024

Right, I'll refactor that BCD algorithm then. Thanks!

@Hardvan Hardvan closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants