Skip to content

Update Sparsity.java #5744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Swarali-31
Copy link

@Swarali-31 Swarali-31 commented Oct 12, 2024

Tried to make it more optimised.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Tried to make it more optimised.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (4a03f42) to head (0674ad4).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/misc/Sparsity.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5744      +/-   ##
============================================
+ Coverage     63.91%   63.92%   +0.01%     
+ Complexity     4167     4166       -1     
============================================
  Files           582      582              
  Lines         16302    16301       -1     
  Branches       3148     3146       -2     
============================================
+ Hits          10419    10420       +1     
+ Misses         5457     5455       -2     
  Partials        426      426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please remove main and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@Swarali-31
Copy link
Author

Swarali-31 commented Oct 13, 2024 via email

Added the unit test and removed the main method.
@Swarali-31 Swarali-31 requested a review from siriak October 13, 2024 06:51
@Swarali-31 Swarali-31 closed this Oct 13, 2024
@Swarali-31 Swarali-31 reopened this Oct 13, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 15, 2024
Copy link

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants