-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Update Sparsity.java #5744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sparsity.java #5744
Conversation
Tried to make it more optimised.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5744 +/- ##
============================================
+ Coverage 63.91% 63.92% +0.01%
+ Complexity 4167 4166 -1
============================================
Files 582 582
Lines 16302 16301 -1
Branches 3148 3146 -2
============================================
+ Hits 10419 10420 +1
+ Misses 5457 5455 -2
Partials 426 426 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, could you please remove main and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
yes sure!
…On Sun, Oct 13, 2024 at 11:54 AM Andrii Siriak ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The code looks good, could you please remove main and add some JUnit
tests? (see
https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms
)
—
Reply to this email directly, view it on GitHub
<#5744 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASDTQYATIQYAHQAEJCILG5DZ3IGZ5AVCNFSM6AAAAABP2YT2IGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUHAZDIMBXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Added the unit test and removed the main method.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
Tried to make it more optimised.
clang-format -i --style=file path/to/your/file.java