Skip to content

feat:Add SwapNumbersUsingXor algo with JUnit tests #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Tanmay-Singh3004
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (4a03f42) to head (8094e2d).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5734      +/-   ##
============================================
+ Coverage     63.91%   63.93%   +0.02%     
- Complexity     4167     4169       +2     
============================================
  Files           582      583       +1     
  Lines         16302    16306       +4     
  Branches       3148     3148              
============================================
+ Hits          10419    10425       +6     
+ Misses         5457     5456       -1     
+ Partials        426      425       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tanmay-Singh3004 Tanmay-Singh3004 marked this pull request as ready for review October 12, 2024 11:25
@siriak
Copy link
Member

siriak commented Oct 13, 2024

It's not an algorithm, it's a trick. You could just return [a, b] from the method and get the same result, so the xor in this method is not useful to the caller

@siriak siriak closed this Oct 13, 2024
@Tanmay-Singh3004 Tanmay-Singh3004 deleted the feature/swap-using-xor branch October 13, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants