Skip to content

feat: add johnson's algorithm #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2024
Merged

feat: add johnson's algorithm #5712

merged 3 commits into from
Oct 12, 2024

Conversation

saahil-mahato
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (31de2db) to head (c16be86).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5712      +/-   ##
============================================
+ Coverage     63.74%   63.88%   +0.14%     
- Complexity     4134     4167      +33     
============================================
  Files           579      580       +1     
  Lines         16209    16273      +64     
  Branches       3120     3140      +20     
============================================
+ Hits          10332    10396      +64     
  Misses         5453     5453              
  Partials        424      424              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saahil-mahato saahil-mahato marked this pull request as ready for review October 11, 2024 04:29
@saahil-mahato
Copy link
Contributor Author

@alxkm Please review this. Thanks.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit ac65af4 into TheAlgorithms:master Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants