Skip to content

Add cipher class, cipher tests, enhance docs in 'AtbashCipher.java' #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

Krounosity
Copy link
Contributor

  • [✅] I have read CONTRIBUTING.md.
  • [✅] This pull request is all my own work -- I have not plagiarized it.
  • [✅] All filenames are in PascalCase.
  • [✅] All functions and variable names follow Java naming conventions.
  • [✅] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [✅] All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.95%. Comparing base (2040df8) to head (36fdaf8).

Files with missing lines Patch % Lines
...n/java/com/thealgorithms/ciphers/AtbashCipher.java 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5690      +/-   ##
============================================
+ Coverage     62.90%   62.95%   +0.04%     
- Complexity     4032     4044      +12     
============================================
  Files           566      567       +1     
  Lines         16012    16030      +18     
  Branches       3081     3084       +3     
============================================
+ Hits          10073    10091      +18     
  Misses         5524     5524              
  Partials        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krounosity Krounosity marked this pull request as ready for review October 10, 2024 03:18
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 11, 2024 05:40
@siriak
Copy link
Member

siriak commented Oct 11, 2024

Please update with the latest master branch

@Krounosity
Copy link
Contributor Author

Looks good, thanks!

Thank you!

@Krounosity
Copy link
Contributor Author

Please update with the latest master branch

Done, do check

@siriak siriak merged commit 2338428 into TheAlgorithms:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants