Skip to content

Hactoberfest 2024 Contribution #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Vinay8git
Copy link

@Vinay8git Vinay8git commented Oct 9, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.93%. Comparing base (b190cb7) to head (7f10968).
Report is 43 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5686      +/-   ##
============================================
+ Coverage     54.75%   58.93%   +4.18%     
- Complexity     3453     3771     +318     
============================================
  Files           538      556      +18     
  Lines         15583    15942     +359     
  Branches       2961     3038      +77     
============================================
+ Hits           8532     9395     +863     
+ Misses         6694     6144     -550     
- Partials        357      403      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saahil-mahato
Copy link
Contributor

saahil-mahato commented Oct 10, 2024

Building interactive CLI is good but please add tests instead. Thank you.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace main with JUnit tests

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 12, 2024
Copy link

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants