Skip to content

Add tests, remove main in LowerBound #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 12, 2024
Merged

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 9, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.52%. Comparing base (138793d) to head (411af46).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5672      +/-   ##
============================================
+ Coverage     63.38%   63.52%   +0.13%     
- Complexity     4090     4097       +7     
============================================
  Files           575      575              
  Lines         16096    16085      -11     
  Branches       3091     3090       -1     
============================================
+ Hits          10203    10218      +15     
+ Misses         5474     5450      -24     
+ Partials        419      417       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 9, 2024 07:19
siriak
siriak previously approved these changes Oct 10, 2024
@siriak
Copy link
Member

siriak commented Oct 10, 2024

Please fix PR checks

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 11, 2024

Done!

@Hardvan Hardvan requested a review from siriak October 11, 2024 02:02
@siriak siriak merged commit b81671e into TheAlgorithms:master Oct 12, 2024
6 checks passed
Chiefpatwal pushed a commit to Chiefpatwal/Java_os that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants