Skip to content

fix columnarTranspositionCipher and typos in Test #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix columnarTranspositionCipher and typos in Test #5649

merged 2 commits into from
Oct 9, 2024

Conversation

SAIVARDHAN15
Copy link
Contributor

…herTest

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.35%. Comparing base (029dd85) to head (761dd5e).

Files with missing lines Patch % Lines
...lgorithms/ciphers/ColumnarTranspositionCipher.java 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5649   +/-   ##
=========================================
  Coverage     59.35%   59.35%           
  Complexity     3796     3796           
=========================================
  Files           556      556           
  Lines         15927    15927           
  Branches       3040     3040           
=========================================
  Hits           9454     9454           
  Misses         6069     6069           
  Partials        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 6e6028e into TheAlgorithms:master Oct 9, 2024
6 checks passed
Chiefpatwal pushed a commit to Chiefpatwal/Java_os that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants