Skip to content

fixed ColumnarTranspositionCipher and added tests for it #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fixed ColumnarTranspositionCipher and added tests for it #5620

wants to merge 1 commit into from

Conversation

SAIVARDHAN15
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.75%. Comparing base (ee6cd64) to head (9bf2860).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...lgorithms/ciphers/ColumnarTranspositionCipher.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5620      +/-   ##
============================================
+ Coverage     54.73%   54.75%   +0.01%     
- Complexity     3453     3454       +1     
============================================
  Files           538      538              
  Lines         15583    15583              
  Branches       2961     2961              
============================================
+ Hits           8530     8532       +2     
+ Misses         6695     6694       -1     
+ Partials        358      357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove main and add JUnit tests

@SAIVARDHAN15
Copy link
Contributor Author

Please remove main and add JUnit tests

recently, a PR regarding tests for ColumnarTranspositionCipher was merged. So shall I create a PR by just removing the main?

@SAIVARDHAN15 SAIVARDHAN15 closed this by deleting the head repository Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants