Skip to content

feat: add QuadraticEquationSolver and test cases #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

sailok
Copy link
Contributor

@sailok sailok commented Oct 7, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (5dcf6c0) to head (d45551f).

Files with missing lines Patch % Lines
...m/thealgorithms/maths/QuadraticEquationSolver.java 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5619      +/-   ##
============================================
+ Coverage     58.11%   58.14%   +0.02%     
- Complexity     3676     3679       +3     
============================================
  Files           546      547       +1     
  Lines         15796    15815      +19     
  Branches       3006     3009       +3     
============================================
+ Hits           9180     9195      +15     
- Misses         6225     6227       +2     
- Partials        391      393       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 7, 2024 21:15
@siriak siriak merged commit bd9e324 into TheAlgorithms:master Oct 7, 2024
6 checks passed
@sailok sailok deleted the quad-equation branch October 8, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants