Skip to content

Added Space Optimized Solution to Subset sum problem #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 10, 2024

Conversation

Rupa-Rd
Copy link
Contributor

@Rupa-Rd Rupa-Rd commented Oct 6, 2024

Solved #5600

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.77%. Comparing base (79544c8) to head (b9a12fe).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5612      +/-   ##
============================================
- Coverage     62.77%   62.77%   -0.01%     
- Complexity     4020     4024       +4     
============================================
  Files           564      565       +1     
  Lines         15932    15939       +7     
  Branches       3073     3076       +3     
============================================
+ Hits          10001    10005       +4     
- Misses         5520     5521       +1     
- Partials        411      413       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no files changed in this PR

@Rupa-Rd
Copy link
Contributor Author

Rupa-Rd commented Oct 8, 2024

There are no files changed in this PR

@siriak, Kindly verify it!

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JUnit tests

@Rupa-Rd
Copy link
Contributor Author

Rupa-Rd commented Oct 10, 2024

Please add JUnit tests

@siriak Added JUnit test.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 10, 2024 20:43
@siriak siriak merged commit 7326ab2 into TheAlgorithms:master Oct 10, 2024
6 checks passed
Chiefpatwal pushed a commit to Chiefpatwal/Java_os that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants