Skip to content

Add JobSchedulingWithDeadline.java new algorithm with Junit tests #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 9, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 6, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.86%. Comparing base (5c79e5d) to head (2442dff).

Files with missing lines Patch % Lines
...gorithms/scheduling/JobSchedulingWithDeadline.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5608      +/-   ##
============================================
+ Coverage     58.83%   58.86%   +0.02%     
- Complexity     3766     3768       +2     
============================================
  Files           555      556       +1     
  Lines         15930    15951      +21     
  Branches       3036     3040       +4     
============================================
+ Hits           9372     9389      +17     
- Misses         6155     6157       +2     
- Partials        403      405       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 6, 2024 07:45
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 8, 2024

I have included arrivalTime in the algorithm as suggested.

@Hardvan Hardvan requested a review from siriak October 8, 2024 09:59
@siriak siriak enabled auto-merge (squash) October 9, 2024 06:31
@siriak siriak merged commit 4bcab89 into TheAlgorithms:master Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants