Skip to content

Refactor BipartiteGraphDFS.java, add Junit tests #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 6, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.06%. Comparing base (2001a09) to head (da1edad).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5606      +/-   ##
============================================
+ Coverage     54.87%   55.06%   +0.18%     
- Complexity     3467     3477      +10     
============================================
  Files           539      539              
  Lines         15628    15607      -21     
  Branches       2969     2965       -4     
============================================
+ Hits           8576     8594      +18     
+ Misses         6694     6655      -39     
  Partials        358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 6, 2024 07:14
@Hardvan Hardvan requested a review from alxkm October 6, 2024 14:07
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 6, 2024

Implemented the suggested changes.

@alxkm
Copy link
Contributor

alxkm commented Oct 6, 2024

After update branch build, there are appeared unused imports

https://github.com/TheAlgorithms/Java/actions/runs/11203917148/job/31141698441?pr=5606

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 6, 2024

Oh right, I removed the unused imports now.

@alxkm alxkm merged commit 387707f into TheAlgorithms:master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants