Skip to content

Add tests for A5Cipher.java, improve class & function documentation #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 6, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@github-actions github-actions bot force-pushed the a5cipher_add_tests branch from e2cd96d to 000e388 Compare October 6, 2024 05:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.85%. Comparing base (93cfa86) to head (94c7648).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5594      +/-   ##
============================================
+ Coverage     56.80%   56.85%   +0.05%     
- Complexity     3600     3601       +1     
============================================
  Files           545      545              
  Lines         15723    15723              
  Branches       2995     2995              
============================================
+ Hits           8931     8939       +8     
+ Misses         6415     6406       -9     
- Partials        377      378       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 6, 2024 05:29
siriak
siriak previously approved these changes Oct 7, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 7, 2024 14:20
@siriak siriak merged commit 26e8ead into TheAlgorithms:master Oct 7, 2024
6 checks passed
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants