Skip to content

Enhance class & function documentation in CircularBuffer.java #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 5, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (640d823) to head (c8f60d2).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5582   +/-   ##
=========================================
  Coverage     66.22%   66.23%           
- Complexity     4428     4430    +2     
=========================================
  Files           606      606           
  Lines         16845    16848    +3     
  Branches       3241     3242    +1     
=========================================
+ Hits          11156    11159    +3     
  Misses         5240     5240           
  Partials        449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 5, 2024 14:24
@Hardvan Hardvan requested a review from alxkm October 12, 2024 12:56
alxkm
alxkm previously approved these changes Oct 13, 2024
alxkm
alxkm previously approved these changes Oct 15, 2024
@siriak
Copy link
Member

siriak commented Oct 15, 2024

Please fix tests, they never stop

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 15, 2024

I have refactored the test cases and fixed the infinite execution problem.

@Hardvan Hardvan requested a review from alxkm October 15, 2024 10:14
@alxkm alxkm merged commit f1aceea into TheAlgorithms:master Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants