Skip to content

Feature/line clipping algorithms #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ShikariSohan
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 55.53%. Comparing base (357fc6a) to head (8be5a23).

Files with missing lines Patch % Lines
...ava/com/thealgorithms/lineclipping/utils/Line.java 30.76% 6 Missing and 3 partials ⚠️
...va/com/thealgorithms/lineclipping/utils/Point.java 30.76% 6 Missing and 3 partials ⚠️
...om/thealgorithms/lineclipping/CohenSutherland.java 87.03% 6 Missing and 1 partial ⚠️
...va/com/thealgorithms/lineclipping/LiangBarsky.java 88.88% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5580      +/-   ##
============================================
+ Coverage     55.42%   55.53%   +0.11%     
- Complexity     3492     3520      +28     
============================================
  Files           540      544       +4     
  Lines         15609    15725     +116     
  Branches       2965     2991      +26     
============================================
+ Hits           8651     8733      +82     
- Misses         6599     6621      +22     
- Partials        359      371      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShikariSohan ShikariSohan force-pushed the feature/line-clipping-algorithms branch 3 times, most recently from 1fab98d to 1fe32ae Compare October 5, 2024 09:08
@ShikariSohan ShikariSohan force-pushed the feature/line-clipping-algorithms branch from 1fe32ae to c8214e5 Compare October 5, 2024 09:55
@ShikariSohan ShikariSohan marked this pull request as ready for review October 5, 2024 10:00
@siriak siriak enabled auto-merge (squash) October 7, 2024 12:12
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit c45b2b8 into TheAlgorithms:master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants