Skip to content

Add Tests for HillCipher.java #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

bennybebo
Copy link
Contributor

  • [x ] I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized it.
  • [x ] All filenames are in PascalCase.
  • [x ] All functions and variable names follow Java naming conventions.
  • [x ] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x ] All new code is formatted with clang-format -i --style=file path/to/your/file.java

Refactored HillCipher.java to remove Scanner dependency and make it testable

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.96%. Comparing base (389d1d7) to head (deeddd2).

Files with missing lines Patch % Lines
...ain/java/com/thealgorithms/ciphers/HillCipher.java 89.09% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5562      +/-   ##
============================================
+ Coverage     53.45%   53.96%   +0.50%     
- Complexity     3365     3385      +20     
============================================
  Files           534      534              
  Lines         15453    15413      -40     
  Branches       2950     2942       -8     
============================================
+ Hits           8261     8317      +56     
+ Misses         6843     6746      -97     
- Partials        349      350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennybebo bennybebo marked this pull request as ready for review October 3, 2024 21:22
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 4, 2024 17:16
@siriak siriak merged commit 393337f into TheAlgorithms:master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants