Skip to content

updated CreateAndDetectLoop with test #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 9, 2024
Merged

Conversation

albinsabu2023
Copy link
Contributor

Above algorithm helps to find the length of loop in linkedlist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (b54cc21) to head (688b48b).

Files with missing lines Patch % Lines
...thms/datastructures/lists/CreateAndDetectLoop.java 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5561      +/-   ##
============================================
+ Coverage     58.59%   58.80%   +0.20%     
- Complexity     3749     3759      +10     
============================================
  Files           554      554              
  Lines         15922    15908      -14     
  Branches       3030     3028       -2     
============================================
+ Hits           9330     9354      +24     
+ Misses         6195     6154      -41     
- Partials        397      400       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Oct 4, 2024

It's already present here

. Please improve the existing implementation (remove main, add tests, etc.)

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JUnit tests and fix PR build and Clang checks

@albinsabu2023 albinsabu2023 changed the title added program to find length of loop in a linkedlist updated CreateAndDetectLoop with test Oct 7, 2024
@albinsabu2023
Copy link
Contributor Author

Am i missing something ? Cuz I didnt get any response @arindam89 @siriak @BurkHufnagel

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 9, 2024 05:45
@siriak siriak merged commit 403649d into TheAlgorithms:master Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants