Skip to content

fix: changing location of others to their meaningful respective places #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

BKarthik7
Copy link
Contributor

fix: changing location of others to their meaningful respective places

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@BKarthik7 BKarthik7 marked this pull request as draft October 3, 2024 17:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (393337f) to head (4a9977e).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5559      +/-   ##
============================================
+ Coverage     53.94%   53.98%   +0.03%     
- Complexity     3385     3388       +3     
============================================
  Files           534      535       +1     
  Lines         15413    15429      +16     
  Branches       2942     2942              
============================================
+ Hits           8315     8329      +14     
- Misses         6747     6748       +1     
- Partials        351      352       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BKarthik7 BKarthik7 marked this pull request as ready for review October 3, 2024 18:10
@BKarthik7
Copy link
Contributor Author

BKarthik7 commented Oct 3, 2024

@siriak could you please review this

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 4, 2024 17:45
@siriak siriak merged commit 042d458 into TheAlgorithms:master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants