-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Add MedianOfTwoSortedArrays.java
new algorithm
#5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MedianOfTwoSortedArrays.java
new algorithm
#5554
Conversation
…rdvan/Java into median_sorted_arrays_new_algo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
============================================
+ Coverage 55.97% 58.23% +2.26%
- Complexity 3535 3701 +166
============================================
Files 544 550 +6
Lines 15704 15872 +168
Branches 2988 3023 +35
============================================
+ Hits 8790 9243 +453
+ Misses 6545 6234 -311
- Partials 369 395 +26 ☔ View full report in Codecov by Sentry. |
It looks like it's leetcode, so according to the rules of this repository it can't be added. https://github.com/TheAlgorithms/Java/blob/master/CONTRIBUTING.md What do you think @siriak |
I understand the concern about it being a LeetCode problem. However, I believe this implementation touches on a valid algorithm that has practical applications. Given its relevance and utility in algorithm studies, I think it warrants consideration for inclusion in the repository. |
@Hardvan could you provide some links that explain this algorithm and its applications outside of leetcode context? If no, we cannot include it as it's too specific and only appears in the context of coding competitions. |
@siriak The Algorithms/Python repository includes the "Median of Two Sorted Arrays" algorithm as part of its directory, indicating it is recognized as a valid algorithm beyond coding competitions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then resolve conflicts and I'll review
Conflicts resolved! |
src/test/java/com/thealgorithms/divideandconquer/MedianOfTwoSortedArraysTest.java
Outdated
Show resolved
Hide resolved
…nto median_sorted_arrays_new_algo
I have refactored the test code to use Parameterized tests instead, |
clang-format -i --style=file path/to/your/file.java