Skip to content

feat: Remove duplicate implementation of Dutch National Flag Sort Algorithm #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

sailok
Copy link
Contributor

@sailok sailok commented Oct 3, 2024

Dutch National Flag Sort Algorithm has been implemented at two places:

Removed the prior implementation in favour of the second one.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.92%. Comparing base (7b934af) to head (63b98ec).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5541      +/-   ##
============================================
+ Coverage     52.84%   52.92%   +0.08%     
+ Complexity     3306     3305       -1     
============================================
  Files           529      528       -1     
  Lines         15361    15330      -31     
  Branches       2926     2922       -4     
============================================
- Hits           8117     8113       -4     
+ Misses         6911     6882      -29     
- Partials        333      335       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alxkm alxkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is another duplicate, and the implementation that remains is more general.

@alxkm alxkm merged commit 48a2980 into TheAlgorithms:master Oct 3, 2024
6 checks passed
@sailok sailok deleted the dnf-clean-up branch October 4, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants